ES|QL Empty index resolution #135601
Closed
ES|QL Empty index resolution #135601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>breaking
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @idegtiarenko, I've created a changelog YAML for you. Note that since this PR is labelled |
There was a problem hiding this comment.
IMHO it makes sense.
The only thing that doesn't really make much sense to me is the result:
from nothing*
{
"columns": [
{
"name": "<no-fields>",
"type": "null"
}
],
"values": []
}
That <no-fields> could be problematic, also because it sticks there even if you add new fields with EVAL.
Since we are moving towards accepting empty plans, it would make sense to return no columns.
# Conflicts: # x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/plugin/IndexResolutionIT.java
|
Replaced with #135826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change
FROM data,index-*is successfully resolves todataindex only butFROM index-*fails.This change aligns behavior by always allowing empty index resolutions in * patterns.
Now index resolution is also consistent with
GET /data,index-*/_searchandGET /index-*/_search.Related to: S2D24